small ux improvements

This commit is contained in:
2026-04-13 15:59:46 +02:00
parent b06858c602
commit 2917e71db1
3 changed files with 125 additions and 79 deletions
+2 -4
View File
@@ -72,7 +72,7 @@ class _CollectionPageState extends State<CollectionPage> {
selected: selected, selected: selected,
onTap: () { onTap: () {
if (selected) { if (selected) {
onCancelSelectionPressed(); deselectBookmark();
setState(() {}); setState(() {});
} else if (selectedBookmarkId != -1 && !selected) { } else if (selectedBookmarkId != -1 && !selected) {
selectedBookmarkId = bookmark.id; selectedBookmarkId = bookmark.id;
@@ -131,7 +131,7 @@ class _CollectionPageState extends State<CollectionPage> {
bottomNavigationBar: selectedBookmarkId > 0 bottomNavigationBar: selectedBookmarkId > 0
? ListItemActionsWidget( ? ListItemActionsWidget(
onDeletePressed: onDeleteBookmarkPressed, onDeletePressed: onDeleteBookmarkPressed,
onCancelPressed: onCancelSelectionPressed, onCancelPressed: deselectBookmark,
onEditPressed: () => editBookmark( onEditPressed: () => editBookmark(
bookmarks.firstWhere( bookmarks.firstWhere(
(element) => element.id == selectedBookmarkId, (element) => element.id == selectedBookmarkId,
@@ -158,8 +158,6 @@ class _CollectionPageState extends State<CollectionPage> {
); );
} }
void onCancelSelectionPressed() => deselectBookmark();
void onDeleteBookmarkPressed() { void onDeleteBookmarkPressed() {
Storage.deleteBookmarkById( Storage.deleteBookmarkById(
selectedBookmarkId, selectedBookmarkId,
+50 -9
View File
@@ -6,6 +6,8 @@ import '../model/collection.dart';
import '../service/bookmarks_provider.dart'; import '../service/bookmarks_provider.dart';
import '../service/shared_link_provider.dart'; import '../service/shared_link_provider.dart';
import '../service/storage.dart'; import '../service/storage.dart';
import '../widgets/collection_page_widgets/list_item_actions_widget.dart'
show ListItemActionsWidget;
import '../widgets/create_bookmark_collection_dialog.dart'; import '../widgets/create_bookmark_collection_dialog.dart';
import 'collection_page.dart'; import 'collection_page.dart';
import 'search_page.dart' show SearchPage; import 'search_page.dart' show SearchPage;
@@ -23,6 +25,7 @@ class CollectionsListPage extends StatefulWidget {
class _CollectionsListPageState extends State<CollectionsListPage> { class _CollectionsListPageState extends State<CollectionsListPage> {
bool addingNewBookmark = false; bool addingNewBookmark = false;
var bookmarkCountMap = <int, int>{}; var bookmarkCountMap = <int, int>{};
int selectedCollectionId = -1;
Widget bottomSheetBuilder(BuildContext context) { Widget bottomSheetBuilder(BuildContext context) {
final titleTextFieldController = TextEditingController( final titleTextFieldController = TextEditingController(
@@ -52,11 +55,27 @@ class _CollectionsListPageState extends State<CollectionsListPage> {
BuildContext context, BuildContext context,
Collection collection, Collection collection,
) { ) {
final selected = selectedCollectionId == collection.id;
return ListTile( return ListTile(
title: Text(collection.name), title: Text(collection.name),
onTap: () => navigateToCollection(collection.id), onTap: () {
onLongPress: () => onEditCollection(collection), if (selected) {
deselectCollection();
setState(() {});
} else if (selectedCollectionId != -1 && !selected) {
selectedCollectionId = collection.id;
setState(() {});
} else {
navigateToCollection(collection.id);
}
},
onLongPress: () => addingNewBookmark
? null
: setState(() {
selectedCollectionId = collection.id;
}),
leading: const Icon(Icons.list_rounded), leading: const Icon(Icons.list_rounded),
selected: selected,
trailing: Text( trailing: Text(
bookmarkCountMap[collection.id]?.toString() ?? '0', bookmarkCountMap[collection.id]?.toString() ?? '0',
style: Theme.of(context).textTheme.bodyMedium, style: Theme.of(context).textTheme.bodyMedium,
@@ -74,13 +93,8 @@ class _CollectionsListPageState extends State<CollectionsListPage> {
builder: (context) => CreateBookmarkCollectionDialog( builder: (context) => CreateBookmarkCollectionDialog(
selectedCollection: selectedCollection, selectedCollection: selectedCollection,
onSavePressed: onCollectionSaved, onSavePressed: onCollectionSaved,
onDeletePressed: () {
Storage.deleteCollection(
selectedCollection,
).whenComplete(() => setState(() {}));
},
), ),
); ).whenComplete(deselectCollection);
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
@@ -89,7 +103,12 @@ class _CollectionsListPageState extends State<CollectionsListPage> {
addingNewBookmark = addingNewBookmark =
Provider.of<SharedLinkProvider>(context).currentMapsLinkMetadata != Provider.of<SharedLinkProvider>(context).currentMapsLinkMetadata !=
null; null;
return Scaffold( return PopScope(
canPop: selectedCollectionId == -1,
onPopInvokedWithResult: (didPop, result) {
if (didPop == false) deselectCollection();
},
child: Scaffold(
appBar: AppBar( appBar: AppBar(
title: addingNewBookmark title: addingNewBookmark
? Text(AppLocalizations.of(context)!.chooseCollection) ? Text(AppLocalizations.of(context)!.chooseCollection)
@@ -139,6 +158,16 @@ class _CollectionsListPageState extends State<CollectionsListPage> {
), ),
), ),
) )
: selectedCollectionId > 0
? ListItemActionsWidget(
onDeletePressed: onDeleteCollectionPressed,
onCancelPressed: deselectCollection,
onEditPressed: () => onEditCollection(
collections.firstWhere(
(element) => element.id == selectedCollectionId,
),
),
)
: null, : null,
floatingActionButton: FloatingActionButton( floatingActionButton: FloatingActionButton(
onPressed: onAddButtonPressed, onPressed: onAddButtonPressed,
@@ -161,6 +190,18 @@ class _CollectionsListPageState extends State<CollectionsListPage> {
: Center( : Center(
child: Text(AppLocalizations.of(context)!.tipCreateCollections), child: Text(AppLocalizations.of(context)!.tipCreateCollections),
), ),
),
); );
} }
void onDeleteCollectionPressed() {
Storage.deleteCollectionById(
selectedCollectionId,
).whenComplete(() => deselectCollection());
}
void deselectCollection() {
selectedCollectionId = -1;
setState(() {});
}
} }
+7
View File
@@ -163,6 +163,13 @@ class Storage {
await saveCollections(collections); await saveCollections(collections);
} }
static Future<void> deleteCollectionById(int collectionId) async {
final collections = loadCollections();
await deleteCollection(
collections.firstWhere((collection) => collection.id == collectionId),
);
}
static Map<String, int> getStats() { static Map<String, int> getStats() {
final statsJson = _prefs.getString(_statsKey) ?? '{}'; final statsJson = _prefs.getString(_statsKey) ?? '{}';
final stats = jsonDecode(statsJson) as Map<String, dynamic>; final stats = jsonDecode(statsJson) as Map<String, dynamic>;