Merge pull request '[fix] Added basic locatlization' (#2) from development into main

Reviewed-on: #2

.gitea/workflows/android_build.yml

@@ -30,17 +30,27 @@ jobs:
       - name: Get commit message and determine version bump
         id: version
         run: |
-          COMMIT_MSG="${{ github.event.head_commit.message }}"
-          
+          COMMIT_MSG=$(git log -1 --pretty=%B)
+          HEAD_REF="${{ github.head_ref }}"
+          echo "DEBUG: Commit message: '$COMMIT_MSG'"
+          echo "DEBUG: Head ref: '$HEAD_REF'"
+
           if [[ $COMMIT_MSG == [fix]* ]]; then
             BUMP_TYPE="patch"
           elif [[ $COMMIT_MSG == [feature]* ]]; then
             BUMP_TYPE="minor"
           elif [[ $COMMIT_MSG == [release]* ]]; then
             BUMP_TYPE="major"
+          elif [[ $HEAD_REF == fix/* ]]; then
+            BUMP_TYPE="patch"
+          elif [[ $HEAD_REF == feature/* ]] || [[ $HEAD_REF == feat/* ]]; then
+            BUMP_TYPE="minor"
+          elif [[ $HEAD_REF == release/* ]] || [[ $HEAD_REF == hotfix/* ]]; then
+            BUMP_TYPE="major"
           else
             BUMP_TYPE="none"
           fi
+
           
           LATEST_TAG=$(git describe --tags --abbrev=0 2>/dev/null || echo "v0.0.0")
           LATEST_TAG=${LATEST_TAG#v}

l10n.yaml

@@ -0,0 +1,3 @@
+arb-dir: lib/l10n
+template-arb-file: app_en.arb
+output-localization-file: app_localizations.dart

lib/l10n/app_de.arb

@@ -0,0 +1,27 @@
+{
+    "@@locale": "de", 
+    "addToCollection": "Speichern in {collection_name}",
+    "@addToCollection": {
+        "placeholders": {
+            "collection_name" : {
+                "type": "String"
+            }
+        }
+    },
+    "cancel": "Abbrechen",
+    "chooseCollection": "Sammlung auswählen",
+    "collections": "Sammlungen",
+    "tipCreateCollections": "Erstelle deine erste Sammlung!",
+    "search": "Suche",
+    "createBookmark": "Lesezeichen erstellen",
+    "createCollection": "Sammlung erstellen",
+    "create": "Erstellen",
+    "delete": "Löschen",
+    "add": "Hinzufügen",
+    "startSearching": "Suche etwas",
+    "tipNoResults": "Keine Suchergebnisse gefunden",
+    "collectionName": "Name der Sammlung",
+    "bookmarkTitle": "Titel des Lesezeichens",
+    "url": "Url",
+    "description": "Beschreibung"
+}

lib/l10n/app_en.arb

@@ -0,0 +1,27 @@
+{
+    "@@locale": "en", 
+    "addToCollection": "Add to {collection_name}",
+    "@addToCollection": {
+        "placeholders": {
+            "collection_name" : {
+                "type": "String"
+            }
+        }
+    },
+    "cancel": "Cancel",
+    "chooseCollection": "Choose Collection",
+    "collections": "Collections",
+    "tipCreateCollections": "Create your first Collection to get started!",
+    "search": "Search",
+    "createBookmark": "Create Bookmark",
+    "createCollection": "Create Collection",
+    "create": "Create",
+    "delete": "Delete",
+    "add": "Add",
+    "startSearching": "Start searching",
+    "tipNoResults": "There are no results that match your search",
+    "collectionName": "Collection Name",
+    "bookmarkTitle": "Bookmark Title",
+    "url": "Url",
+    "description": "Description"
+}

lib/l10n/app_localizations.dart

@@ -0,0 +1,236 @@
+import 'dart:async';
+
+import 'package:flutter/foundation.dart';
+import 'package:flutter/widgets.dart';
+import 'package:flutter_localizations/flutter_localizations.dart';
+import 'package:intl/intl.dart' as intl;
+
+import 'app_localizations_de.dart';
+import 'app_localizations_en.dart';
+
+// ignore_for_file: type=lint
+
+/// Callers can lookup localized strings with an instance of AppLocalizations
+/// returned by `AppLocalizations.of(context)`.
+///
+/// Applications need to include `AppLocalizations.delegate()` in their app's
+/// `localizationDelegates` list, and the locales they support in the app's
+/// `supportedLocales` list. For example:
+///
+/// ```dart
+/// import 'l10n/app_localizations.dart';
+///
+/// return MaterialApp(
+///   localizationsDelegates: AppLocalizations.localizationsDelegates,
+///   supportedLocales: AppLocalizations.supportedLocales,
+///   home: MyApplicationHome(),
+/// );
+/// ```
+///
+/// ## Update pubspec.yaml
+///
+/// Please make sure to update your pubspec.yaml to include the following
+/// packages:
+///
+/// ```yaml
+/// dependencies:
+///   # Internationalization support.
+///   flutter_localizations:
+///     sdk: flutter
+///   intl: any # Use the pinned version from flutter_localizations
+///
+///   # Rest of dependencies
+/// ```
+///
+/// ## iOS Applications
+///
+/// iOS applications define key application metadata, including supported
+/// locales, in an Info.plist file that is built into the application bundle.
+/// To configure the locales supported by your app, you’ll need to edit this
+/// file.
+///
+/// First, open your project’s ios/Runner.xcworkspace Xcode workspace file.
+/// Then, in the Project Navigator, open the Info.plist file under the Runner
+/// project’s Runner folder.
+///
+/// Next, select the Information Property List item, select Add Item from the
+/// Editor menu, then select Localizations from the pop-up menu.
+///
+/// Select and expand the newly-created Localizations item then, for each
+/// locale your application supports, add a new item and select the locale
+/// you wish to add from the pop-up menu in the Value field. This list should
+/// be consistent with the languages listed in the AppLocalizations.supportedLocales
+/// property.
+abstract class AppLocalizations {
+  AppLocalizations(String locale)
+    : localeName = intl.Intl.canonicalizedLocale(locale.toString());
+
+  final String localeName;
+
+  static AppLocalizations? of(BuildContext context) {
+    return Localizations.of<AppLocalizations>(context, AppLocalizations);
+  }
+
+  static const LocalizationsDelegate<AppLocalizations> delegate =
+      _AppLocalizationsDelegate();
+
+  /// A list of this localizations delegate along with the default localizations
+  /// delegates.
+  ///
+  /// Returns a list of localizations delegates containing this delegate along with
+  /// GlobalMaterialLocalizations.delegate, GlobalCupertinoLocalizations.delegate,
+  /// and GlobalWidgetsLocalizations.delegate.
+  ///
+  /// Additional delegates can be added by appending to this list in
+  /// MaterialApp. This list does not have to be used at all if a custom list
+  /// of delegates is preferred or required.
+  static const List<LocalizationsDelegate<dynamic>> localizationsDelegates =
+      <LocalizationsDelegate<dynamic>>[
+        delegate,
+        GlobalMaterialLocalizations.delegate,
+        GlobalCupertinoLocalizations.delegate,
+        GlobalWidgetsLocalizations.delegate,
+      ];
+
+  /// A list of this localizations delegate's supported locales.
+  static const List<Locale> supportedLocales = <Locale>[
+    Locale('de'),
+    Locale('en'),
+  ];
+
+  /// No description provided for @addToCollection.
+  ///
+  /// In en, this message translates to:
+  /// **'Add to {collection_name}'**
+  String addToCollection(String collection_name);
+
+  /// No description provided for @cancel.
+  ///
+  /// In en, this message translates to:
+  /// **'Cancel'**
+  String get cancel;
+
+  /// No description provided for @chooseCollection.
+  ///
+  /// In en, this message translates to:
+  /// **'Choose Collection'**
+  String get chooseCollection;
+
+  /// No description provided for @collections.
+  ///
+  /// In en, this message translates to:
+  /// **'Collections'**
+  String get collections;
+
+  /// No description provided for @tipCreateCollections.
+  ///
+  /// In en, this message translates to:
+  /// **'Create your first Collection to get started!'**
+  String get tipCreateCollections;
+
+  /// No description provided for @search.
+  ///
+  /// In en, this message translates to:
+  /// **'Search'**
+  String get search;
+
+  /// No description provided for @createBookmark.
+  ///
+  /// In en, this message translates to:
+  /// **'Create Bookmark'**
+  String get createBookmark;
+
+  /// No description provided for @createCollection.
+  ///
+  /// In en, this message translates to:
+  /// **'Create Collection'**
+  String get createCollection;
+
+  /// No description provided for @create.
+  ///
+  /// In en, this message translates to:
+  /// **'Create'**
+  String get create;
+
+  /// No description provided for @delete.
+  ///
+  /// In en, this message translates to:
+  /// **'Delete'**
+  String get delete;
+
+  /// No description provided for @add.
+  ///
+  /// In en, this message translates to:
+  /// **'Add'**
+  String get add;
+
+  /// No description provided for @startSearching.
+  ///
+  /// In en, this message translates to:
+  /// **'Start searching'**
+  String get startSearching;
+
+  /// No description provided for @tipNoResults.
+  ///
+  /// In en, this message translates to:
+  /// **'There are no results that match your search'**
+  String get tipNoResults;
+
+  /// No description provided for @collectionName.
+  ///
+  /// In en, this message translates to:
+  /// **'Collection Name'**
+  String get collectionName;
+
+  /// No description provided for @bookmarkTitle.
+  ///
+  /// In en, this message translates to:
+  /// **'Bookmark Title'**
+  String get bookmarkTitle;
+
+  /// No description provided for @url.
+  ///
+  /// In en, this message translates to:
+  /// **'Url'**
+  String get url;
+
+  /// No description provided for @description.
+  ///
+  /// In en, this message translates to:
+  /// **'Description'**
+  String get description;
+}
+
+class _AppLocalizationsDelegate
+    extends LocalizationsDelegate<AppLocalizations> {
+  const _AppLocalizationsDelegate();
+
+  @override
+  Future<AppLocalizations> load(Locale locale) {
+    return SynchronousFuture<AppLocalizations>(lookupAppLocalizations(locale));
+  }
+
+  @override
+  bool isSupported(Locale locale) =>
+      <String>['de', 'en'].contains(locale.languageCode);
+
+  @override
+  bool shouldReload(_AppLocalizationsDelegate old) => false;
+}
+
+AppLocalizations lookupAppLocalizations(Locale locale) {
+  // Lookup logic when only language code is specified.
+  switch (locale.languageCode) {
+    case 'de':
+      return AppLocalizationsDe();
+    case 'en':
+      return AppLocalizationsEn();
+  }
+
+  throw FlutterError(
+    'AppLocalizations.delegate failed to load unsupported locale "$locale". This is likely '
+    'an issue with the localizations generation tool. Please file an issue '
+    'on GitHub with a reproducible sample app and the gen-l10n configuration '
+    'that was used.',
+  );
+}

lib/l10n/app_localizations_de.dart

@@ -0,0 +1,63 @@
+// ignore: unused_import
+import 'package:intl/intl.dart' as intl;
+import 'app_localizations.dart';
+
+// ignore_for_file: type=lint
+
+/// The translations for German (`de`).
+class AppLocalizationsDe extends AppLocalizations {
+  AppLocalizationsDe([String locale = 'de']) : super(locale);
+
+  @override
+  String addToCollection(String collection_name) {
+    return 'Speichern in $collection_name';
+  }
+
+  @override
+  String get cancel => 'Abbrechen';
+
+  @override
+  String get chooseCollection => 'Sammlung auswählen';
+
+  @override
+  String get collections => 'Sammlungen';
+
+  @override
+  String get tipCreateCollections => 'Erstelle deine erste Sammlung!';
+
+  @override
+  String get search => 'Suche';
+
+  @override
+  String get createBookmark => 'Lesezeichen erstellen';
+
+  @override
+  String get createCollection => 'Sammlung erstellen';
+
+  @override
+  String get create => 'Erstellen';
+
+  @override
+  String get delete => 'Löschen';
+
+  @override
+  String get add => 'Hinzufügen';
+
+  @override
+  String get startSearching => 'Suche etwas';
+
+  @override
+  String get tipNoResults => 'Keine Suchergebnisse gefunden';
+
+  @override
+  String get collectionName => 'Name der Sammlung';
+
+  @override
+  String get bookmarkTitle => 'Titel des Lesezeichens';
+
+  @override
+  String get url => 'Url';
+
+  @override
+  String get description => 'Beschreibung';
+}

lib/l10n/app_localizations_en.dart

@@ -0,0 +1,64 @@
+// ignore: unused_import
+import 'package:intl/intl.dart' as intl;
+import 'app_localizations.dart';
+
+// ignore_for_file: type=lint
+
+/// The translations for English (`en`).
+class AppLocalizationsEn extends AppLocalizations {
+  AppLocalizationsEn([String locale = 'en']) : super(locale);
+
+  @override
+  String addToCollection(String collection_name) {
+    return 'Add to $collection_name';
+  }
+
+  @override
+  String get cancel => 'Cancel';
+
+  @override
+  String get chooseCollection => 'Choose Collection';
+
+  @override
+  String get collections => 'Collections';
+
+  @override
+  String get tipCreateCollections =>
+      'Create your first Collection to get started!';
+
+  @override
+  String get search => 'Search';
+
+  @override
+  String get createBookmark => 'Create Bookmark';
+
+  @override
+  String get createCollection => 'Create Collection';
+
+  @override
+  String get create => 'Create';
+
+  @override
+  String get delete => 'Delete';
+
+  @override
+  String get add => 'Add';
+
+  @override
+  String get startSearching => 'Start searching';
+
+  @override
+  String get tipNoResults => 'There are no results that match your search';
+
+  @override
+  String get collectionName => 'Collection Name';
+
+  @override
+  String get bookmarkTitle => 'Bookmark Title';
+
+  @override
+  String get url => 'Url';
+
+  @override
+  String get description => 'Description';
+}

lib/main.dart

@@ -1,5 +1,7 @@
 import 'package:flutter/material.dart';
+import 'package:flutter_localizations/flutter_localizations.dart';
 import 'package:provider/provider.dart';
+import 'l10n/app_localizations.dart';
 import 'pages/collection_page.dart';
 import 'pages/collections_list_page.dart';
 import 'pages/search_page.dart';
@@ -66,6 +68,13 @@ class _MapsBookmarksState extends State<MapsBookmarks>
   @override
   Widget build(BuildContext context) {
     return MaterialApp(
+      localizationsDelegates: [
+        AppLocalizations.delegate,
+        GlobalMaterialLocalizations.delegate,
+        GlobalWidgetsLocalizations.delegate,
+        GlobalCupertinoLocalizations.delegate,
+      ],
+      supportedLocales: [Locale('en'), Locale('de')],
       navigatorKey: _navigatorKey,
       theme: lightTheme,
       darkTheme: darkTheme,

lib/pages/collection_page.dart

@@ -1,6 +1,7 @@
 import 'package:flutter/material.dart';
 import 'package:provider/provider.dart';
 
+import '../l10n/app_localizations.dart';
 import '../model/bookmark.dart';
 import '../model/maps_link_metadata.dart';
 import '../service/bookmarks_provider.dart';
@@ -89,13 +90,15 @@ class _CollectionPageState extends State<CollectionPage> {
     return Scaffold(
       appBar: AppBar(
         title: selectedMapsLink != null
-            ? Text('Add to ${collection.name}')
+            ? Text(
+                AppLocalizations.of(context)!.addToCollection(collection.name),
+              )
             : Text(collection.name),
         actions: [
           if (selectedMapsLink != null)
             TextButton(
               onPressed: () => provider.removeCurrentMapsLink(),
-              child: Text('Cancel'),
+              child: Text(AppLocalizations.of(context)!.cancel),
             ),
         ],
       ),

lib/pages/collections_list_page.dart

@@ -1,6 +1,7 @@
 import 'package:flutter/material.dart';
 import 'package:provider/provider.dart';
 
+import '../l10n/app_localizations.dart';
 import '../model/collection.dart';
 import '../service/bookmarks_provider.dart';
 import '../service/shared_link_provider.dart';
@@ -88,13 +89,13 @@ class _CollectionsListPageState extends State<CollectionsListPage> {
     return Scaffold(
       appBar: AppBar(
         title: addingNewBookmark
-            ? Text('Choose Collection')
-            : Text('Collections'),
+            ? Text(AppLocalizations.of(context)!.chooseCollection)
+            : Text(AppLocalizations.of(context)!.collections),
         actions: [
           if (addingNewBookmark)
             TextButton(
               onPressed: () => provider.removeCurrentMapsLink(),
-              child: Text('Cancel'),
+              child: Text(AppLocalizations.of(context)!.cancel),
             )
           else
             IconButton(
@@ -116,7 +117,9 @@ class _CollectionsListPageState extends State<CollectionsListPage> {
               ),
               itemCount: collections.length,
             )
-          : Center(child: Text('Create your first Collection to get started!')),
+          : Center(
+              child: Text(AppLocalizations.of(context)!.tipCreateCollections),
+            ),
     );
   }
 }

lib/pages/search_page.dart

@@ -1,5 +1,6 @@
 import 'package:flutter/material.dart';
 import 'package:provider/provider.dart';
+import '../l10n/app_localizations.dart';
 import '../service/search_provider.dart';
 import '../widgets/search_widgets/search_bar_widget.dart';
 import '../widgets/search_widgets/search_results_widget.dart';
@@ -12,7 +13,7 @@ class SearchPage extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     return Scaffold(
-      appBar: AppBar(title: Text('Search')),
+      appBar: AppBar(title: Text(AppLocalizations.of(context)!.search)),
       body: Column(
         children: [
           SearchBarWidget(

lib/widgets/create_bookmark_collection_dialog.dart

@@ -1,6 +1,7 @@
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
 
+import '../l10n/app_localizations.dart';
 import '../model/collection.dart';
 import 'edit_dialog_widgets/edit_dialog_actions.dart' show EditDialogActions;
 import 'edit_dialog_widgets/edit_dialog_title.dart';
@@ -41,7 +42,7 @@ class CreateBookmarkCollectionDialog extends StatelessWidget {
         ],
         decoration: InputDecoration(
           // TODO: Localize
-          labelText: 'Collection Name',
+          labelText: AppLocalizations.of(context)!.collectionName,
           border: OutlineInputBorder(borderRadius: BorderRadius.circular(10)),
         ),
       ),

lib/widgets/create_bookmark_dialog.dart

@@ -1,6 +1,7 @@
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
 
+import '../l10n/app_localizations.dart';
 import '../model/bookmark.dart';
 import '../model/maps_link_metadata.dart';
 import 'edit_dialog_widgets/edit_dialog_actions.dart';
@@ -59,7 +60,7 @@ class CreateBookmarkDialog extends StatelessWidget {
                 FilteringTextInputFormatter.deny(RegExp(r'\s\s+')),
               ],
               decoration: InputDecoration(
-                labelText: 'Bookmark Title',
+                labelText: AppLocalizations.of(context)!.bookmarkTitle,
                 border: OutlineInputBorder(
                   borderRadius: BorderRadius.circular(10),
                 ),
@@ -76,7 +77,7 @@ class CreateBookmarkDialog extends StatelessWidget {
                 FilteringTextInputFormatter.deny(RegExp(r'\s\s+')),
               ],
               decoration: InputDecoration(
-                labelText: 'Url',
+                labelText: AppLocalizations.of(context)!.url,
                 border: OutlineInputBorder(
                   borderRadius: BorderRadius.circular(10),
                 ),
@@ -93,7 +94,7 @@ class CreateBookmarkDialog extends StatelessWidget {
                 FilteringTextInputFormatter.deny(RegExp(r'\s\s+')),
               ],
               decoration: InputDecoration(
-                labelText: 'Description',
+                labelText: AppLocalizations.of(context)!.description,
                 border: OutlineInputBorder(
                   borderRadius: BorderRadius.circular(10),
                 ),

lib/widgets/edit_dialog_widgets/edit_dialog_actions.dart

@@ -2,6 +2,8 @@ import 'package:flutter/material.dart'
     show TextButton, FloatingActionButton, Icons;
 import 'package:flutter/widgets.dart';
 
+import '../../l10n/app_localizations.dart';
+
 class EditDialogActions extends StatelessWidget {
   const EditDialogActions({super.key, required this.onSavePressed});
   final VoidCallback onSavePressed;
@@ -13,7 +15,7 @@ class EditDialogActions extends StatelessWidget {
       children: [
         TextButton(
           onPressed: () => Navigator.of(context).pop(),
-          child: Text('Cancel'),
+          child: Text(AppLocalizations.of(context)!.cancel),
         ),
         FloatingActionButton(onPressed: onSavePressed, child: Icon(Icons.save)),
       ],

lib/widgets/search_widgets/search_results_widget.dart

@@ -1,6 +1,7 @@
 import 'package:flutter/material.dart';
 import 'package:provider/provider.dart';
 
+import '../../l10n/app_localizations.dart';
 import '../../model/bookmark.dart';
 import '../../service/notifying.dart';
 import '../../service/search_provider.dart';
@@ -51,6 +52,6 @@ class _SearchResultsWidgetState extends State<SearchResultsWidget> {
         itemCount: filteredBookmarks.length,
       );
     }
-    return Center(child: Text('Start searching'));
+    return Center(child: Text(AppLocalizations.of(context)!.tipNoResults));
   }
 }

pubspec.lock

@@ -102,6 +102,11 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "6.0.0"
+  flutter_localizations:
+    dependency: "direct main"
+    description: flutter
+    source: sdk
+    version: "0.0.0"
   flutter_test:
     dependency: "direct dev"
     description: flutter
@@ -136,6 +141,14 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "4.1.2"
+  intl:
+    dependency: "direct main"
+    description:
+      name: intl
+      sha256: "3df61194eb431efc39c4ceba583b95633a403f46c9fd341e550ce0bfa50e9aa5"
+      url: "https://pub.dev"
+    source: hosted
+    version: "0.20.2"
   leak_tracker:
     dependency: transitive
     description:

pubspec.yaml

@@ -3,7 +3,7 @@ description: "A new way to save google maps bookmarks"
 
 publish_to: 'none'
 
-version: 0.0.0
+version: 0.0.18
 
 environment:
   sdk: ^3.9.2
@@ -18,6 +18,9 @@ dependencies:
   provider: ^6.1.5+1
   metadata_fetch: ^0.4.2
   url_launcher: ^6.3.2
+  flutter_localizations:
+    sdk: flutter
+  intl: any
 
 dev_dependencies:
   flutter_test:
@@ -26,5 +29,5 @@ dev_dependencies:
   flutter_lints: ^6.0.0
 
 flutter:
-
+  generate: true
   uses-material-design: true